Open
Conversation
Contributor
|
The changes in bin/git-bc-show-eligible LGTM, however for some reason this commit adds 7 empty files, and it is not clear why this would be needed. |
Author
|
You are right. There was a change in permissions. Let me roll-back. |
Contributor
|
Remember to rebase the code as well, because I merged something today. |
ShadowTemplate
force-pushed
the
multiple-exclude-files
branch
from
d6c7fc8 to
5620ef3
Compare
ShadowTemplate
force-pushed
the
multiple-exclude-files
branch
from
5620ef3 to
9bccc4a
Compare
Author
|
Done! |
kirawrath
approved these changes
Feb 21, 2022
bin/git-bc-show-eligible
Outdated
| def add_exclude_hash(excludes: typing.List[str], commit: str) -> None: | ||
| if commit in excludes: | ||
| print(f'Commit {commit} already in the exclude list ({EXCLUDES_PATH}).') | ||
| print(f'Commit {commit} already in some exclude list ({EXCLUDES_PATHS}).') |
There was a problem hiding this comment.
Suggested change
| print(f'Commit {commit} already in some exclude list ({EXCLUDES_PATHS}).') | |
| print(f'Commit {commit} already in one of exclude lists in ({EXCLUDES_PATHS}).') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will allow us to use multiple exclude files.
We can take advantage of it to have (large) repo-specific exclude files, e.g. for the manuals repo.
Please, see the follow-up message on Slack.